Skip to content

use 64-bit integer for parameter tests#197

Merged
wjwwood merged 2 commits intomasterfrom
fix_windows_warning_pr_193
Mar 31, 2017
Merged

use 64-bit integer for parameter tests#197
wjwwood merged 2 commits intomasterfrom
fix_windows_warning_pr_193

Conversation

@wjwwood
Copy link
Copy Markdown
Member

@wjwwood wjwwood commented Mar 31, 2017

@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Mar 31, 2017
@wjwwood wjwwood self-assigned this Mar 31, 2017
@wjwwood wjwwood mentioned this pull request Mar 31, 2017
Merged
@wjwwood
Copy link
Copy Markdown
Member Author

wjwwood commented Mar 31, 2017

Ok, CI looks like the warning is gone now:

  • Linux:
    • Build Status
  • macOS:
    • Build Status
  • Windows:
    • Build Status (unrelated test failure)

mikaelarguedas
mikaelarguedas approved these changes Mar 31, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this 👍

@wjwwood wjwwood merged commit 67efe8e into master Mar 31, 2017
@wjwwood wjwwood deleted the fix_windows_warning_pr_193 branch March 31, 2017 22:08
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@wjwwood wjwwood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wjwwood @mikaelarguedas