Skip to content

Sros2 cmake macros#75

Merged
jacobperron merged 7 commits intoros2:masterfrom
ross-desmond:sros2_cmake_macros
Jan 26, 2019
Merged

Sros2 cmake macros#75
jacobperron merged 7 commits intoros2:masterfrom
ross-desmond:sros2_cmake_macros

Conversation

@ross-desmond
Copy link
Copy Markdown
Contributor

Adds cmake macros for generating keys and keystore for nodes at compile time.

Enables addition of new colcon built packages in this repo
@tfoote tfoote added the in review Waiting for review (Kanban column) label Jan 11, 2019
@ross-desmond
Copy link
Copy Markdown
Contributor Author

Depends on #74

@ross-desmond
Copy link
Copy Markdown
Contributor Author

These changes split from the original PR #71 and has all changes requested for the cmake macro from that review

@mjcarroll
Copy link
Copy Markdown
Member

mjcarroll commented Jan 15, 2019

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting out the cmake package 👍

endif()
find_program(PROGRAM ros2)
if (NOT PROGRAM)
message("Unable to find ros2cli, have you sourced your ros setup files?")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add ros2cli as a build and build_export dependency to the package.xml so we don't have to rely on sourcing a setup file in the case that we're building alongside ros2cli.

@mjcarroll
Copy link
Copy Markdown
Member

@ross-desmond Just as a housekeeping note, we're moving forward on making a release for the patch, and this will get in the first sync after the patch release.

@ross-desmond
Copy link
Copy Markdown
Contributor Author

Awesome, making changes...

@mjcarroll
Copy link
Copy Markdown
Member

Disregard that CI, I think I used the wrong repos file...

@ross-desmond
Copy link
Copy Markdown
Contributor Author

Awesome, making changes...

Looks like all changes are accounted for.

@jacobperron
Copy link
Copy Markdown
Member

CI up to sros2_cmake:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 53fc6f7 into ros2:master Jan 26, 2019
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants