Separate loading of Identity and Permission Certificate Authorities#66
Closed
ruffsl wants to merge 1 commit intoros2:masterfrom
Closed
Separate loading of Identity and Permission Certificate Authorities#66ruffsl wants to merge 1 commit intoros2:masterfrom
ruffsl wants to merge 1 commit intoros2:masterfrom
Conversation
This was referenced Aug 30, 2018
Merged
Member
|
Thanks @ruffsl ! These branches were either very out of date (in the case of the sros2 repository) or fell behind master since the PRs were opened. In the future I recommend you to rebase the branches on the latest master before opening PRs, as well as set the PRs' labels as "in review" to get reviews in a timely manner (as you are a member of the ros2 organization, your PRs get labeled as "in progress" automatically). I opened a set of rebased PRs (#67 and connected PRs) to test this change. @codebot FYI |
Member
Author
|
rebased version #67 merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #43
Includes minimal changes to support the use of loading separate Identity and Permission Certificate Authorities for DDS security. For simplicity the common CA is merely renamed as two different files expected in the security root path.