add missing enable_liveliness_protection tag in governance files#44
Merged
mikaelarguedas merged 1 commit intomasterfrom Apr 26, 2018
Merged
Conversation
Member
Author
|
@ros2/team this and connected PR are ready for review |
wjwwood
approved these changes
Apr 25, 2018
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this tag is defined by the spec and was missing from our generated files.
Connext ignores it but Fast-RTPS parser flags the governance file as invalid if this tag is missing.
A follow up PR should be created on
test_securityto update the security files accordingly.