Skip to content

Switch to get_rmw_additional_env#339

Merged
ahcorde merged 2 commits intorollingfrom
yadu/get_rmw_additional_env
Mar 27, 2025
Merged

Switch to get_rmw_additional_env#339
ahcorde merged 2 commits intorollingfrom
yadu/get_rmw_additional_env

Conversation

@Yadunund
Copy link
Copy Markdown
Member

@Yadunund Yadunund commented Mar 23, 2025

Depends on ros2/ros2cli#992.

Yadunund and others added 2 commits March 23, 2025 22:36
@Yadunund
Switch to get_rmw_additional_env
acd4794 
Signed-off-by: Yadunund <yadunund@gmail.com>
@ahcorde
review feedback
6268ba9 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@Yadunund
Copy link
Copy Markdown
Member Author

Yadunund commented Mar 24, 2025 •
edited
Loading

  • Linux-aarch64 Build Status

@Yadunund Yadunund mentioned this pull request Mar 25, 2025
Closed
7 tasks
@ros-discourse
Copy link
Copy Markdown

ros-discourse commented Mar 25, 2025

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-pmc-minutes-for-march-25-2025/42807/1

@Yadunund
Copy link
Copy Markdown
Member Author

Yadunund commented Mar 26, 2025 •
edited by ahcorde
Loading

Gist (default ros2.repos file with changes from this branch and corresponding ros2cli branch): https://gist.githubusercontent.com/Yadunund/c4074b12ea5bdedcddae7b60f60c34bc/raw/04abbe75ee2c139bfb65a667735b5112e5fb7565/ros2_ci.repos
BUILD_ARGS: --packages-up-to sros2
TEST_ARGS: --packages-select sros2

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but ros2/ros2cli#992 is still draft.

@Yadunund Yadunund mentioned this pull request Mar 26, 2025
Open
15 tasks
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Mar 26, 2025 •
edited
Loading

with rmw_zenoh:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit aeb8a97 into rolling Mar 27, 2025
3 of 6 checks passed
@ahcorde ahcorde deleted the yadu/get_rmw_additional_env branch March 27, 2025 22:21
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (8fd7b70) to head (6268ba9).
Report is 1 commits behind head on rolling.

Additional details and impacted files 
@@           Coverage Diff            @@
##           rolling     #339   +/-   ##
========================================
  Coverage    88.94%   88.94%           
========================================
  Files           24       24           
  Lines          615      615           
  Branches        64       64           
========================================
  Hits           547      547           
  Misses          50       50           
  Partials        18       18
Flag Coverage Δ
unittests 88.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yadunund @ros-discourse @ahcorde @fujitatomoya