Skip to content

Skip mypy test on platforms using importlib_resources#258

Merged
mikaelarguedas merged 1 commit intomasterfrom
cottsay/skip_mypy
Apr 10, 2021
Merged

Skip mypy test on platforms using importlib_resources#258
mikaelarguedas merged 1 commit intomasterfrom
cottsay/skip_mypy

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented Apr 9, 2021 •
edited
Loading

Platform-agnostic alternative to #248

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • macOS Build Status
  • Windows Build Status

@cottsay cottsay self-assigned this Apr 9, 2021
@cottsay cottsay force-pushed the cottsay/skip_mypy branch from 8bcffa9 to f049cbb Compare April 9, 2021 21:21
@cottsay
Skip mypy test on platforms using importlib_resources
fdf814e 
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay force-pushed the cottsay/skip_mypy branch from f049cbb to fdf814e Compare April 9, 2021 21:26
clalancette
clalancette approved these changes Apr 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, of course. This is a way better solution than mine, and would work on other platforms that have this problem. Big thumbs up from me assuming CI is happy.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2021

Codecov Report

Merging #258 (fdf814e) into master (c0801b8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   77.25%   77.25%           
=======================================
  Files          25       25           
  Lines         664      664           
  Branches       55       55           
=======================================
  Hits          513      513           
  Misses        131      131           
  Partials       20       20
Flag Coverage Δ
unittests 77.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lsrd/sros2/sros2/sros2/api/_artifact_generation.py
...wmozlsrd/sros2/sros2/sros2/verb/generate_policy.py
...rrwmozlsrd/sros2/sros2/sros2/verb/list_enclaves.py
.../src/rrwmozlsrd/sros2/sros2/sros2/verb/__init__.py
..._ws/src/rrwmozlsrd/sros2/sros2/sros2/_utilities.py
...zlsrd/sros2/sros2/sros2/policy/schemas/__init__.py
.../rrwmozlsrd/sros2/sros2/sros2/keystore/__init__.py
...os_ws/src/rrwmozlsrd/sros2/sros2/sros2/__init__.py
...rc/rrwmozlsrd/sros2/sros2/sros2/policy/__init__.py
...srd/sros2/sros2/sros2/policy/templates/__init__.py
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0801b8...fdf814e. Read the comment docs.

mikaelarguedas
mikaelarguedas approved these changes Apr 10, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mikaelarguedas mikaelarguedas merged commit 667973f into master Apr 10, 2021
@mikaelarguedas mikaelarguedas deleted the cottsay/skip_mypy branch April 10, 2021 05:34
@mikaelarguedas mikaelarguedas mentioned this pull request Apr 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@cottsay cottsay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cottsay @clalancette @mikaelarguedas