[foxy-backport] Make use of ros_testing to test policy generation. (#214)#254
Merged
jacobperron merged 1 commit intofoxyfrom Jan 11, 2022
Merged
[foxy-backport] Make use of ros_testing to test policy generation. (#214)#254jacobperron merged 1 commit intofoxyfrom
jacobperron merged 1 commit intofoxyfrom
Conversation
* Make use of ros_testing to test policy generation. Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com> * Skip test_generate_policy.py tests on Windows. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Revert "Skip test_generate_policy.py tests on Windows." This reverts commit c68f0a0. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Wait for expected ROS graph state. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Boost discovery delay. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Please linter. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Skip tests using RTI Connext w/o a daemon. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Bump generate_policy execution timeout on Windows. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Bump generate_policy execution timeout on Windows again. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Co-authored-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
j-rivero
approved these changes
Sep 2, 2021
j-rivero
left a comment
There was a problem hiding this comment.
Build and tests are good on my system I did not detect any problem in the backport.
Member
|
macOS is no longer a supported platform, but I'll go ahead and merge this backport pending CI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to address #251