Merged
Conversation
Also, guard against name collisions from lingering nodes by making the expected node, topic, and services names more verbose. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
|
If this is flaky only on Windows why skip the test on all platforms? |
Member
Author
|
I've only noticed the test failing on Windows, but conceivably it could also fail on other platforms if other nodes are running at the same time as the test. I can make an exception only in case of Windows if you prefer. |
Member
|
Since the upstream ticket has speculation that it might only happen on Windows due to its differences in signal handling I would rather only skip it on Windows for now. We skip it on other platforms if we notice the problem there too. |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
Windows Debug: |
Member
|
You could keep using a decorator: |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
Aug 29, 2019
Member
Author
|
Windows Debug: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, guard against name collisions from lingering nodes by making the
expected node, topic, and services names more verbose.
Resolves #143