Closed
Conversation
Contributor
|
So this PR is doing too much in one go. Also, as you say we can't take it as-is because we need to maintain compatibility with both Qt5 (which is what we use on Ubuntu) and x86_64. What I'm going to do here is to make this a draft PR, but this will need significant changes to be considered for inclusion. |
Author
|
Yes I absolutely agree with you, my apologies; I will work on it and hopefully convert it into something useful 👍 |
Contributor
|
I'm going to close this one out for now, because we can't get it in in its current state. Do feel free to open a new, more targeted one in the future though. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add qt6 and arm64 compatibility for the latest mac os big sur on arm64 (m1) --please note: this code is not final yet, this might have to get its own issue branch on the base repo. Will break things on x86_64 unless some backwards compatibility is added.
Tested on mac os big sur 11.4, with qt6 installed through brew. compiles and runs successfully