Merged
Conversation
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Contributor
Author
|
@jacobperron could you take a look when you got time? |
clalancette
requested changes
Oct 12, 2020
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Since we are now explicitly relying on rcutils, please add a build dependency to the package.xml and do a find_package in the CMakeLists.txt.
Otherwise, the code looks good.
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Contributor
Author
that is correct, thanks! it's done with 77a5ac4 |
clalancette
approved these changes
Oct 13, 2020
Contributor
|
CI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close ros2/ros2#856
Signed-off-by: Tomoya.Fujita Tomoya.Fujita@sony.com
all rviz related tests are pass,