-
Notifications
You must be signed in to change notification settings - Fork 284
Drop Qt5 support in rolling? #1634
Copy link
Copy link
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Description
Hi, I noticed that Rviz currently supports both qt5 and qt6 in the rolling branch, this creates some challenges in the following scenario:
- osrf/ros:rolling-desktop-full(with rviz installed) ships only qt5
- gz_sim is now pulling qt6 https://github.com/gazebo-release/gz_sim_vendor/blob/ec3712a0b251b20dab8471224c733ef8c28cbb2a/package.xml#L65-L75
- this leads to mixed qt version
With gz_sim and related packages already migrating to qt6: can we consider dropping qt5 support in the main branch? Or
can we update the package.xml to install the qt6 dependencies since we are prioritizing qt6 in the cmakelist?
rviz/rviz_common/CMakeLists.txt
Line 34 in c2cc241
| find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Widgets) |
Motivation
Align better with other core packages
Design / Implementation Considerations
Update package.xml
Additional Information
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request