change generators to IDL-based pipeline#39
Merged
dirk-thomas merged 11 commits intomasterfrom Mar 12, 2019
Merged
Conversation
e267a04 to
f3330ed
Compare
f3330ed to
2f3b3c6
Compare
hidmic
reviewed
Nov 27, 2018
Contributor
hidmic
left a comment
There was a problem hiding this comment.
Mostly minor comments. I see the pattern emerging across PRs and I worry about duplication a bit.
hidmic
reviewed
Dec 5, 2018
76549a3 to
22cfe9a
Compare
fb360ee to
7dc67ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another PR integrating ros2/rosidl#298 step-by-step.
Connected to ros2/rosidl#334
rosidl_typesupport_candrosidl_typesupport_cpppackages to use the new IDL-based extension points.