Provide type support for 'goal_status_array' in action type support#28
Merged
jacobperron merged 2 commits intomasterfrom Jan 29, 2019
Merged
Provide type support for 'goal_status_array' in action type support#28jacobperron merged 2 commits intomasterfrom
jacobperron merged 2 commits intomasterfrom
Conversation
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Contributor
|
@dirk-thomas FYI this PR might affect the rebasing of the IDL PRs |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
sloretz
approved these changes
Jan 29, 2019
Contributor
sloretz
left a comment
There was a problem hiding this comment.
Works on my machine, LGTM with green CI
Member
Author
|
Up to
|
Contributor
I think this should be up to test_msgs or example_interfaces since those are the first packages with an action in them |
Member
Author
Yep, that's right! Up to
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.