Skip to content

Deserialization: floating point bounds check does not permit messages with NaN #162

@oysstu

Description

@oysstu

Bug report

Required Info:

  • Operating System: Linux
  • Installation type: Source, master
  • Version or commit hash: 3dc5872
  • DDS implementation: Fast-RTPS
  • Client library (if applicable): rclpy

Steps to reproduce issue

Running deserialize_message(serialized_message: bytes, message_type) on a message containing a field set to NaN triggers the bounds check added in #128.

assert value >= -3.402823e+38 and value <= 3.402823e+38,
AssertionError: The 'current' field must be a float in [-3.402823e+38, 3.402823e+38]

Expected behavior

The NaN value should be converted to a NaN in python.

The BatteryState message, for example, uses NaNs to flag values that are not measured.

Actual behavior

The conversion triggers an assertion, and fails to deserialize.

Additional information

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions