Skip to content

[Service introspection] service_msgs dependency#24

Merged
clalancette merged 1 commit intorollingfrom
service_introspection
Feb 2, 2023
Merged

[Service introspection] service_msgs dependency#24
clalancette merged 1 commit intorollingfrom
service_introspection

Conversation

@ihasdapie
Copy link
Copy Markdown
Member

Services now depend on service_msgs, adding to rosidl_defaults to forward the dependency to packages that generate interfaces.

ros2/ros2#1285

Signed-off-by: Brian Chen brian.chen@openrobotics.org

@ihasdapie ihasdapie mentioned this pull request Aug 27, 2022
14 tasks
@jacobperron jacobperron self-assigned this Sep 1, 2022
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@jacobperron
Copy link
Copy Markdown
Member

rebased on rolling

Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
@clalancette clalancette force-pushed the service_introspection branch from a3fae0c to abdf892 Compare January 25, 2023 18:28
@clalancette clalancette requested a review from sloretz as a code owner January 25, 2023 18:28
@clalancette
Copy link
Copy Markdown
Contributor

CI for this is in ros2/ros2#1285 (comment)

@clalancette clalancette merged commit a3f753d into rolling Feb 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the service_introspection branch February 2, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants