Conversation
In C++17, Allocator::rebind<>::other is deprecated (and Windows now warns about it). See https://en.cppreference.com/w/cpp/memory/allocator for more information. Switch to std::allocator_traits which works in both C++14 and C++17. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
wjwwood
left a comment
There was a problem hiding this comment.
lgtm
On a related, but not blocking note, Dirk and I realized sometime last year that using custom allocators with our rclcpp API just doesn't work at all. It may still be useful to use this allocator with the message without using it with rclcpp, but that seems like a small likelyhood. One of the possible solutions was to switch to the polymorphic allocator. Having C++17 now opens that possibility up to us as it was added in C++17 and modified somewhat heavily in C++20:
https://en.cppreference.com/w/cpp/memory/polymorphic_allocator
But I still think it would be the right thing to use even now without C++20.
Makes sense. Is there an issue tracking that problem? If not, would you mind opening one (just because I don't have the context here). The failing tests in CI are failing in the nightlies as well, so those are nothing new. I'm going to go ahead and merge this, thanks for the review. |
Good question, I'll look. |
|
I've opened an issue here: #566 |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros2-compatibility-with-c-20/19014/3 |
In C++17, Allocator::rebind<>::other is deprecated (and Windows
now warns about it). See
https://en.cppreference.com/w/cpp/memory/allocator for more information.
Switch to std::allocator_traits which works in both C++14 and C++17.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org