Revert "add to_yaml() function for C++ messages (#523)"#525
Merged
sloretz merged 1 commit intoros2:masterfrom Sep 10, 2020
Merged
Revert "add to_yaml() function for C++ messages (#523)"#525sloretz merged 1 commit intoros2:masterfrom
sloretz merged 1 commit intoros2:masterfrom
Conversation
This reverts commit aac71e5. Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
a55b844 to
9b8b638
Compare
Contributor
Author
|
@dirk-thomas @ivanpauno please take a look. |
Contributor
Author
|
sloretz
approved these changes
Sep 10, 2020
dirk-thomas
approved these changes
Sep 10, 2020
Member
|
This can be merged without waiting for CI. It clearly fixes the regression. I will open a redo PR for it. |
Contributor
Merging. Looks like the Windows job got stuck anyways :( Edit Spoke too soon, I see new console output 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit aac71e5.
This resolves #524