Documentation: action, message, service typesupport and message bounds#472
Merged
Documentation: action, message, service typesupport and message bounds#472
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
brawner
suggested changes
Apr 27, 2020
Contributor
brawner
left a comment
There was a problem hiding this comment.
Not bad, sorry I didn't see this review. But it also looks like there was some file naming refactoring that occurred since this PR was made so that will also need to be addressed.
rosidl_runtime_c/include/rosidl_runtime_c/action_type_support_struct.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/action_type_support_struct.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/action_type_support_struct.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/message_bounds_struct.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/message_bounds_struct.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/message_bounds_struct.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/message_bounds_struct.h
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Member
|
The string functions still lack docblocks. |
11 tasks
brawner
reviewed
Apr 28, 2020
rosidl_runtime_c/include/rosidl_runtime_c/action_type_support_struct.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/message_type_support_struct.h
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
a3856a1 to
0487a6f
Compare
brawner
approved these changes
Apr 29, 2020
rosidl_runtime_c/include/rosidl_runtime_c/u16string_functions.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/u16string_functions.h
Outdated
Show resolved
Hide resolved
dirk-thomas
reviewed
Apr 29, 2020
rosidl_runtime_c/include/rosidl_runtime_c/u16string_functions.h
Outdated
Show resolved
Hide resolved
rosidl_runtime_c/include/rosidl_runtime_c/u16string_functions.h
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
brawner
approved these changes
Apr 30, 2020
| * All strings must be null-terminated. | ||
| * The rosidl_runtime_c__String structure should be deallocated using the given function | ||
| * rosidl_runtime_c__String__fini() when it is no longer needed. | ||
| * Call this function with an already initialized string will leak memory. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Call this function with an already initialized string will leak memory. | |
| * Calling this function with an already initialized string will leak memory. |
Fix here and below.
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
approved these changes
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation action, message, service typesupport and message bounds
Signed-off-by: ahcorde ahcorde@gmail.com