Conversation
…enerator_x and rosidl_runtime_x Signed-off-by: ahcorde <ahcorde@gmail.com>
rosidl_typesupport_introspection_c/resource/msg__type_support.c.em
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
6810e75 to
e533e72
Compare
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
e533e72 to
6433657
Compare
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
643135b to
c76cd28
Compare
|
Commonly a package only provides headers with a namespace / directory matching the package name. Should we consider updating the namespace / directory of the moved headers? If yes, how much code would be affected by this breaking change? |
|
I was trying to do so, but this will require a lot of changes in many packages. I was trying to reduce the amount of noise regarding this change. Also the resources are in the generator but the headers are in the runtime. This will require also some changes in the resources. but if this is the way I can put some time on it |
dirk-thomas
left a comment
There was a problem hiding this comment.
We can land the PR as is. I was mostly wondering if it makes sense / if we want to follow up on the naming afterwards.
Signed-off-by: ahcorde <ahcorde@gmail.com>
a99eb57 to
c069663
Compare
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
Removed |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…itted_rosidl_generator
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
This breaks binary compatibility in its public API. Shouldn't it bump the major version number? |
We will, I assume, when we next release from master. |
Since the packages in this repo have 0.x versions there is no need to bump the major version. Anything can change anytime in pre 1.x versions. Independent of this change the goal is to bring several repos / packages to at least version 1.0 for the Foxy release. |
…itted_rosidl_generator
Signed-off-by: ahcorde <ahcorde@gmail.com>
In MacOS
Windows
|
As discussed in the issue ros2/ros2#442 I have spplited in to
rosidl_generator_candrosidl_generator_cpp.I don't really know if
rosidl_runtime_cppis needed. because this package is not creating any runtime dependency such as a .so/dylib/dll. But I have seen this comment https://github.com/ros2/rosidl/blob/master/rosidl_generator_cpp/include/rosidl_generator_cpp/message_initialization.hpp#L18 from @clalancette and I dediced to splitt it too, also because I think it makes sense for consistency.