Skip to content

Handle INT32_MIN value#375

Merged
mjcarroll merged 1 commit intomasterfrom
jacob/min_int32
May 2, 2019
Merged

Handle INT32_MIN value#375
mjcarroll merged 1 commit intomasterfrom
jacob/min_int32

Conversation

@jacobperron
Copy link
Copy Markdown
Member

Similar to INT64_MIN value, but only because MSVC complains.

Similar to INT64_MIN value, but only because MSVC complains.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label May 1, 2019
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 1, 2019
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented May 2, 2019

Example of the warnings in CI: https://ci.ros2.org/view/packaging/job/packaging_windows/1360/warnings43Result/

  • unary minus operator applied to unsigned type, result still unsigned

@mjcarroll mjcarroll merged commit 169bf20 into master May 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/min_int32 branch May 2, 2019 15:35
@mjcarroll mjcarroll removed the in review Waiting for review (Kanban column) label May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants