Skip to content

Fix relative path syntax for cpplint#947

Merged
jacobperron merged 1 commit intomasterfrom
jacob/update_cpplint_fork
Jan 13, 2022
Merged

Fix relative path syntax for cpplint#947
jacobperron merged 1 commit intomasterfrom
jacob/update_cpplint_fork

Conversation

@jacobperron
Copy link
Copy Markdown
Member

@jacobperron jacobperron commented Jan 11, 2022

@jacobperron jacobperron requested a review from a team as a code owner January 11, 2022 20:52
@jacobperron jacobperron requested review from emersonknapp and jhdcs and removed request for a team January 11, 2022 20:52
@jacobperron
Fix relative path syntax for cpplint
595dc70 
Relates to ament/ament_lint#324

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron force-pushed the jacob/update_cpplint_fork branch from 74a0e55 to 595dc70 Compare January 11, 2022 20:54
@jacobperron jacobperron changed the title Fix include order and relative path syntax for cpplint Fix relative path syntax for cpplint Jan 11, 2022
@jacobperron jacobperron mentioned this pull request Jan 11, 2022
Merged
@gbiggs
Copy link
Copy Markdown
Member

gbiggs commented Jan 12, 2022

CI:

  • Linux Build Status
  • Linux (aarch64) Build Status
  • Windows Build Status

@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Jan 12, 2022

FWIW, I've triggered CI for all PRs related to the cpplint update in the parent ticket: ament/ament_lint#324

jhdcs
jhdcs approved these changes Jan 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple enough change. I'm assuming the reason CI is failing is because cpplint is working now?

@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Jan 12, 2022

CI is passing here: ament/ament_lint#324 (comment)

The ament_cpplint GitHub CI job also appears to be passing (AFAIK, this change is backwards compatible with the old version of cpplint).

The RPr and ament_uncrustify failures looks unrelated to this change (correct me if I'm wrong).

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Jan 12, 2022

The RPr and ament_uncrustify failures looks unrelated to this change (correct me if I'm wrong).

The uncrustify failures is definitely unrelated; the Docker image that setup-action-ros uses needs to be rebuilt.

I'm pretty sure the Rpr jobs have been failing for a while, but I'm less certain of that one.

@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Jan 13, 2022

Going ahead and merging this since ament/ament_lint#324 was merged and I think the CI failures on this PR are unrelated.

@jacobperron jacobperron merged commit 2c68544 into master Jan 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/update_cpplint_fork branch January 13, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes

@jhdcs jhdcs jhdcs approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros2/tooling-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jacobperron @gbiggs @clalancette @jhdcs