Skip to content

Revert "Add callbacks for PlayerClock::jump(time_point) API (#775)"#778

Merged
emersonknapp merged 1 commit intomasterfrom
emersonknapp/revert-775
Jun 11, 2021
Merged

Revert "Add callbacks for PlayerClock::jump(time_point) API (#775)"#778
emersonknapp merged 1 commit intomasterfrom
emersonknapp/revert-775

Conversation

@emersonknapp
Copy link
Copy Markdown
Collaborator

@emersonknapp emersonknapp commented Jun 11, 2021

This reverts commit abd4229 for #775

Windows build started failing, since CI wasn't run for this PR before merging

This reverts commit abd4229.

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp requested a review from a team as a code owner June 11, 2021 19:21
@emersonknapp emersonknapp requested review from jaisontj and prajakta-gokhale and removed request for a team June 11, 2021 19:21
@emersonknapp emersonknapp requested a review from clalancette June 11, 2021 19:22
@emersonknapp
Copy link
Copy Markdown
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/ef088041e86de551f5439fee3bcc47f5/raw/289e108895384a6a31ae47b75d07011c2277c9af/ros2.repos
BUILD args: --packages-up-to rosbag2_cpp rosbag2_tests
TEST args: --packages-select rosbag2_cpp rosbag2_tests
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/8562

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming CI goes green.

Thanks!

@emersonknapp emersonknapp merged commit 758d96b into master Jun 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/revert-775 branch June 11, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants