Add time conversion logic diagrams to time control design#700
Merged
emersonknapp merged 4 commits intomasterfrom Apr 1, 2021
Merged
Add time conversion logic diagrams to time control design#700emersonknapp merged 4 commits intomasterfrom
emersonknapp merged 4 commits intomasterfrom
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
1 task
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Contributor
|
@emersonknapp Quick question. According to your design are we going to advance moving references each time when we a playing message or only by event when we are changing speed/pause or playing next message in pause? |
Collaborator
Author
|
We only advance moving reference on a time control event, which is currently defined as one of the following:
I believe that "play next message while paused" will be implemented using |
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add diagrams and derived equations for converting between playback time and steady time, with explanations. This helps inform discussion around the implementation details as we incrementally implement.
Related Issues
Clarifies behind discussion in #689
Extends #675
Part of #696