Add support for rmw_connextdds#671
Conversation
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
emersonknapp
left a comment
There was a problem hiding this comment.
LGTM assuming green CI - are there any dependencies for this PR? I assume if I just ran ci_launcher now, it would fail on the rmw_connext_cpp tests?
I think you are correct. The merging of this PR will need to be coordinated with changes to the default I'm afraid there will be a short window of instability as all these changes are rolled out, but hopefully we will be able keep all failures to a minimum and make the transition as quick as possible. Re: testing, you may want to try using this modified ros2.repos. |
I bet there is a way to do it without breaking anything :) |
| # disable the following tests for connext | ||
| # due to slower discovery of nodes | ||
| set(SKIP_TEST "") | ||
| if(${rmw_implementation} MATCHES "(.*)connext(.*)") |
There was a problem hiding this comment.
we could keep a (.*)connext(.*)_cpp filter here, which would skip the test for the old rmw_connext_cpp and rmw_connext_dynamic_cpp, but not for rmw_connextdds.
…unity/rmw_connextdds Signed-off-by: Andrea Sorbini <asorbini@rti.com>
clalancette
left a comment
There was a problem hiding this comment.
Seems reasonable to me with green CI.
|
|
|
CI looks good (the warnings in @emersonknapp could you merge this PR? thanks! |
It's not a problem for this PR (it won't make any difference), but it is probably going to be a problem for integrating the new RMW onto ci.ros2.org. But we can address that separately. |
The trick currently in use in ci is that when the So, I would follow the same idea here, ignoring those packages in the ci scripts when |
This PR removes all references to
rmw_connext_cpp, so that it may be replaced byrmw_connextdds.The PR re-enables a test which was previously disabled for Connext.
See rticommunity/rmw_connextdds #9 for a list of related PRs, and an overview of all the changes required to replace ros2/rmw_connext (
rmw_connext_cpp) with rticommunity/rmw_connextdds in the ROS2 source tree.