Merged
Conversation
Signed-off-by: Knese Karsten <karsten@openrobotics.org>
Collaborator
Author
|
CI running only cyclone:
|
Signed-off-by: Knese Karsten <karsten@openrobotics.org>
emersonknapp
approved these changes
Mar 31, 2020
Collaborator
Author
|
@emersonknapp do you have insights about the warnings in the windows build? |
Collaborator
|
Hmm, no, I am confused by it. Looking |
Collaborator
|
I have it on my branch as well #340 - it's related to my changes, i think it shouldn't block you, i have a fix ready within my PR |
Collaborator
|
My question is why did your windows run take 22 mins and mine took 52...? |
Collaborator
Author
|
As far as I can see, you are building your CI with all three RMWs (Connext, FastRTPS, Cyclone) where as mine only builds with cyclone. So there is no typesupprt generation involved besides introspection. |
Collaborator
|
Oh! That makes sense thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #329
as discussed in #329 this change disables the
rosoutpublishers on the publisher test nodes.also, fyi @emersonknapp this also disables the QoS test as it also fails for cyclone.
Signed-off-by: Knese Karsten karsten@openrobotics.org