Query offered QoS profiles for a topic and store in metadata#333
Merged
emersonknapp merged 6 commits intoros2:masterfrom Mar 30, 2020
Merged
Query offered QoS profiles for a topic and store in metadata#333emersonknapp merged 6 commits intoros2:masterfrom
emersonknapp merged 6 commits intoros2:masterfrom
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
zmichaels11
approved these changes
Mar 27, 2020
piraka9011
reviewed
Mar 27, 2020
piraka9011
reviewed
Mar 27, 2020
4338e39 to
e57a6b8
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
e57a6b8 to
c2df921
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
zmichaels11
approved these changes
Mar 27, 2020
piraka9011
approved these changes
Mar 27, 2020
21 tasks
Collaborator
Author
|
@Karsten1987 ping for monday review :) I put more detail on the description for this one. |
Collaborator
Author
|
@emersonknapp - please run this CI job |
Collaborator
Author
The warnings in OSX are from rclcpp, unrelated to this change. |
This was referenced Mar 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #125
Moves https://github.com/ros-tooling/aws-roadmap/issues/215 to Done
This change queries the currently offered QoS profiles for a given topic at the time of subscription, and stores them in the TopicMetadata. This does not use the queried QoS profile in any way, just stores it.
With this in, you will see the string-serialized profiles in both the metadata.yaml file and the sqlite topics table.
This does not handle new publishers that join after subscribing to a topic. We do not currently have a mechanism to change TopicMetadata after initial creation, and do not plan to add this ability for Foxy.
Once we have used the queried QoS profile to subscribe (upcoming change), we will need to make sure to notice late-joining publishers that offer a different QoS profile than we used to subscribe, to warn the user that this has happened.