Skip to content

[foxy] Workaround for failing can_resolve_msg_with_idl_deps test on Windows#1355

Closed
MichaelOrlov wants to merge 2 commits intofoxyfrom
morlov/foxy-workaound_for_failing_msg_def_test
Closed

[foxy] Workaround for failing can_resolve_msg_with_idl_deps test on Windows#1355
MichaelOrlov wants to merge 2 commits intofoxyfrom
morlov/foxy-workaound_for_failing_msg_def_test

Conversation

@MichaelOrlov
Copy link
Copy Markdown
Contributor

@MichaelOrlov MichaelOrlov commented May 26, 2023

@MichaelOrlov MichaelOrlov force-pushed the morlov/foxy-workaound_for_failing_msg_def_test branch from 1acb0f7 to de62eed Compare May 26, 2023 06:51
@MichaelOrlov
Copy link
Copy Markdown
Contributor Author

MichaelOrlov commented May 26, 2023

Gist: https://gist.githubusercontent.com/MichaelOrlov/2e909519f827c1e52e4220c80d825748/raw/0383881f5585014742a4ae375487a19c387093b8/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_adapter rosbag2_storage_mcap
TEST args: --packages-above rosidl_adapter rosbag2_storage_mcap
ROS Distro: foxy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12131

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Copy Markdown
Contributor Author

MichaelOrlov commented May 26, 2023

Re-run CI for focal target
Gist: https://gist.githubusercontent.com/MichaelOrlov/2e909519f827c1e52e4220c80d825748/raw/0383881f5585014742a4ae375487a19c387093b8/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_adapter rosbag2_storage_mcap
TEST args: --packages-above rosidl_adapter rosbag2_storage_mcap
ROS Distro: foxy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12132

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov mentioned this pull request May 26, 2023
Closed
@MichaelOrlov
Copy link
Copy Markdown
Contributor Author

MichaelOrlov commented May 26, 2023

Re-run Widows CI job after fixing expectation in test

  • Windows Build Status

@MichaelOrlov MichaelOrlov changed the title Workaround for failing can_resolve_msg_with_idl_deps test on Windows [foxy] Workaround for failing can_resolve_msg_with_idl_deps test on Windows May 26, 2023
emersonknapp
emersonknapp approved these changes May 26, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morlov-apexai
Workaround for failing can_resolve_msg_with_idl_deps test on Windows
a6a729b 
- Replaces ros2/rosidl#745

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov force-pushed the morlov/foxy-workaound_for_failing_msg_def_test branch from 2415ce3 to c6d4376 Compare May 26, 2023 19:28
@MichaelOrlov
Copy link
Copy Markdown
Contributor Author

MichaelOrlov commented May 26, 2023

Windows CI failed in an unrelated package

Failed   <<< rviz_ogre_vendor [23min 39s, exited with code 1]

Re-running Windows CI job one more time.

  • Windows Build Status

@morlov-apexai
Fix expectation in test on Windows by removing one extra backslash
912c67c 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov force-pushed the morlov/foxy-workaound_for_failing_msg_def_test branch from c6d4376 to 912c67c Compare May 26, 2023 19:35
@MichaelOrlov
Copy link
Copy Markdown
Contributor Author

MichaelOrlov commented May 26, 2023

@MichaelOrlov MichaelOrlov deleted the morlov/foxy-workaound_for_failing_msg_def_test branch September 16, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@quarkytale quarkytale Awaiting requested review from quarkytale

@james-rms james-rms Awaiting requested review from james-rms

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelOrlov @emersonknapp @morlov-apexai