Skip to content

[foxy] Fix YAML_CPP_DLL warnings on Windows#1353

Merged
emersonknapp merged 3 commits intofoxyfrom
emersonknapp/foxy-yaml-cpp-windows-warnings
May 26, 2023
Merged

[foxy] Fix YAML_CPP_DLL warnings on Windows#1353
emersonknapp merged 3 commits intofoxyfrom
emersonknapp/foxy-yaml-cpp-windows-warnings

Conversation

@emersonknapp
Copy link
Copy Markdown
Collaborator

@emersonknapp emersonknapp commented May 25, 2023 •
edited
Loading

Add simple preprocessor checks to avoid redefining the macro to quiet the preexisting Windows warnings.

For an example see https://ci.ros2.org/job/ci_windows/19550/

Related to ros2/rosidl#745

@emersonknapp emersonknapp mentioned this pull request May 25, 2023
Merged
@emersonknapp
[foxy] Fix YAML_CPP_DLL warnings on Windows
dcfadb1 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/foxy-yaml-cpp-windows-warnings branch from d4534a1 to dcfadb1 Compare May 25, 2023 23:04
@emersonknapp emersonknapp self-assigned this May 25, 2023
@emersonknapp
Fix clang-format
93120e8 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Copy Markdown
Collaborator Author

emersonknapp commented May 25, 2023

Gist: https://gist.githubusercontent.com/emersonknapp/b827f35b3921513a03452aaf7408d3f7/raw/fab691609cc094312f0e3c299a893f933cbdd49d/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_storage rosbag2_storage_mcap rosbag2_transport
TEST args: --packages-above rosbag2_storage rosbag2_storage_mcap rosbag2_transport
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12126

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp emersonknapp mentioned this pull request May 25, 2023
Merged
@quarkytale
Copy link
Copy Markdown

quarkytale commented May 26, 2023

This might be relevant here ros2/yaml_cpp_vendor#37

@emersonknapp
Copy link
Copy Markdown
Collaborator Author

emersonknapp commented May 26, 2023 •
edited
Loading

Oops I ran CI against iron - cancelled Windows build and restarted on Foxy

Gist: https://gist.githubusercontent.com/emersonknapp/58bcf3c75062051c39279bddc3e0da3e/raw/b03622f0dd3ed3695b4bc4fd4afba17376afd468/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_storage rosbag2_storage_mcap rosbag2_transport
TEST args: --packages-above rosbag2_storage rosbag2_storage_mcap rosbag2_transport
ROS Distro: foxy

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

MichaelOrlov
MichaelOrlov approved these changes May 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@emersonknapp emersonknapp merged commit c8539c8 into foxy May 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/foxy-yaml-cpp-windows-warnings branch May 26, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@james-rms james-rms Awaiting requested review from james-rms

Assignees

@emersonknapp emersonknapp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emersonknapp @quarkytale @MichaelOrlov