Use thread pool to run benchmark publishers in rosbag2_performance_benchmarking#1250
Use thread pool to run benchmark publishers in rosbag2_performance_benchmarking#1250MichaelOrlov merged 11 commits intoros2:rollingfrom
Conversation
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
…marking (ros2#1242) Signed-off-by: Shane Loretz <sloretz@google.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
…osbag2_performance_benchmarking/config_utils.hpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
…osbag2_performance_benchmarking/thread_pool.hpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
…mark_publishers.cpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
…osbag2_performance_benchmarking/thread_pool.hpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
…osbag2_performance_benchmarking/thread_pool.hpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
MichaelOrlov
left a comment
There was a problem hiding this comment.
@carlossvg LGTM. Thanks for restoring PR.
|
@ros-pull-request-builder retest this please |
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/ca15d2faeb4b9e50d96c0c663ec65a96/raw/6a833de131f461ffff0171ab0b8a2a5490362943/ros2.repos
|
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/6b0258febb43edc9f0e760e6ab243c68/raw/6a833de131f461ffff0171ab0b8a2a5490362943/ros2.repos
|
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/6b0258febb43edc9f0e760e6ab243c68/raw/6a833de131f461ffff0171ab0b8a2a5490362943/ros2.repos
|
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-03-16/30432/1 |
Follow-up from: #1171 (comment)
Related to: #688
Depends on #1153
This PR changes benchmark_publishers to use a thread pool instead of running each publisher in separate threads. The motivation for this change is to overcome a limitation on the number of threads imposed by Cyclone DDS (limited to 128 threads).