-
Notifications
You must be signed in to change notification settings - Fork 305
Closed
Description
The patches in this package suggest to me that it must always build the vendored project, in which case it must specify the dependencies of that project in order to build as a released package. The release job is currently failing due to the absence of pluginlib in the build container. A grep through the patches suggests there are likely other build and runtime dependencies that should be specified.
❯ git grep find_package
CMakeLists.txt:find_package(ament_cmake REQUIRED)
resources/cmakeliststxt.diff:+find_package(ament_cmake REQUIRED)
resources/cmakeliststxt.diff:+find_package(pluginlib 2.0 REQUIRED)
resources/cmakeliststxt.diff: find_package(console_bridge REQUIRED)
resources/cmakeliststxt.diff:-find_package(catkin REQUIRED COMPONENTS cpp_common pluginlib roscpp_serialization roscpp_traits rostime roslz4)
resources/cmakeliststxt.diff: find_package(Boost REQUIRED COMPONENTS date_time filesystem program_options regex)
resources/cmakeliststxt.diff: find_package(BZip2 REQUIRED)
resources/cmakeliststxt.diff:+find_package(ros1_bridge REQUIRED)
resources/cmakeliststxt.diff:+find_package(PkgConfig)
resources/cmakeliststxt.diff:- find_package(rostest)
resources/cmakeliststxt.diff:+# find_package(ament_cmake_gmock)
resources/rosbag1_encryption_patch.diff: find_package(rostest)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels