-
Notifications
You must be signed in to change notification settings - Fork 305
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Description
Like in ROS 1, there should be a chance to control the replaying of a bag file.
spacebar should toggle the start/pause replaying.
s should solely spin the bag once.
Generally, as for now, there is no status feedback given when replaying a bag file. As a first step, there should be a message printed, whether the bag file is currently publishing data or not.
Completion criteria
-
ros2 bag playuseskeyboard_handlerto receive key callbacks -
spacebartoggles pause/resume state for playback -
sdoesplay_next -
ros2 bag playprints a help message when playback starts, explaining these controls
Related issues
Implementation Notes
- May need to bloom-release
keyboard_handlerinto Rolling - it is not yet in use. - May need to expose keybindings to Python layer via Pybind - it makes sense for the CLI to define which keys do what, rather than hardcoding on the C++ end
Testing Notes
- May be difficult to do key-based end-to-end testing. It should be OK to mock the key callbacks
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request