Enable test isolation on a few remaining ros2topic tests#1087
Merged
Enable test isolation on a few remaining ros2topic tests#1087
Conversation
These weren't caught in the first round because they execute based on the runtime-configured RMW implementation, where the others fan out to all available implementations. Signed-off-by: Scott K Logan <logans@cottsay.net>
fujitatomoya
approved these changes
Aug 7, 2025
Member
|
@cottsay we can backport this to |
Member
Author
Eventually, yes. I think there are a couple of supporting PRs in this repository that need to be backported first. I'd like to wait for a few more nightly builds to gain confidence before backporting, but I'll put it on my list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These weren't caught in the first round because they execute based on the runtime-configured RMW implementation, where the others fan out to all available implementations. This (in combination with #1086) should allow the tests to run correctly with
RMW_IMPLEMENTATION=rmw_zenoh_cpp.Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information