Skip to content

Add test for GenericPublisher/Subscriber#97

Merged
christophebedard merged 10 commits intoros2:rollingfrom
h-suzuki-isp:add_generic_pubsub_test
Apr 5, 2024
Merged

Add test for GenericPublisher/Subscriber#97
christophebedard merged 10 commits intoros2:rollingfrom
h-suzuki-isp:add_generic_pubsub_test

Conversation

@h-suzuki-isp
Copy link
Copy Markdown
Contributor

@h-suzuki-isp h-suzuki-isp commented Mar 18, 2024 •
edited by christophebedard
Loading

Please, refer to ros2/rclcpp#2448.

Because I added tracepoint for GenericPublisher and GenericSubscriber, I add some tests to test_tracetools.
I have added the following tests.

  • src/
    • test_generic_ping.cpp
    • test_generic_pong.cpp
  • test/
    • test_generic_pub_sub.py
    • test_generic_subscription.py

action-ros-ci-repos-override: https://gist.githubusercontent.com/christophebedard/9a37e393935913add5ad490aaee26e7f/raw/194c464b68cd138e887f041f50f42c0cbe3f4710/ros2.repos

@h-suzuki-isp h-suzuki-isp mentioned this pull request Mar 18, 2024
Merged
@h-suzuki-isp h-suzuki-isp marked this pull request as ready for review March 19, 2024 04:36
@h-suzuki-isp
Add: test for GenericPublisher/Subscriber
22e24a0 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp
Fix: add test_generic_*.py
17717b5 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp
Fix: copylight
7e32265 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp
Fix: copyright
24f670a 
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
@h-suzuki-isp h-suzuki-isp force-pushed the add_generic_pubsub_test branch from fb6f275 to 24f670a Compare March 21, 2024 02:35
@h-suzuki-isp
correspond to mark_procces
124bd3a 
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Mar 26, 2024 •
edited
Loading

The Rpr__ros2_tracing__ubuntu_noble_amd64 job failure is expected due to the transition to Ubuntu Noble.

The reason why the ros2_tracing / test (ubuntu-22.04, rolling, source, instr-enabled, tp-included) job fails is because only this PR branch gets built; your rclcpp/rcl/rmw_* branches are not used. I've added a repos file to this PR description so that it runs with your other changes. Can you do git commit --amend --no-edit and then force push so that CI runs again? The tests seem to successfully pass locally for me when I use all the relevant branches.

@christophebedard christophebedard self-requested a review March 26, 2024 00:06
@h-suzuki-isp
Fix: copyright
ebac435 
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
@h-suzuki-isp h-suzuki-isp force-pushed the add_generic_pubsub_test branch from f5f8f94 to ebac435 Compare March 26, 2024 01:51
@h-suzuki-isp
Copy link
Copy Markdown
Contributor Author

h-suzuki-isp commented Mar 26, 2024

@christophebedard
Thank you for your help.
As a result of running CI again, the test pass successfully.

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Mar 27, 2024

It looks good to me, but I'm just trying to run the tests with the other rmw implementations too. For some reason I can't get RMW_IMPLEMENTATION=rmw_connextdds to work.

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Mar 27, 2024

It looks good to me, but I'm just trying to run the tests with the other rmw implementations too. For some reason I can't get RMW_IMPLEMENTATION=rmw_connextdds to work.

Oops, I didn't have rti-connext-dds-6.0.1 installed on my system, that's probably why.

christophebedard
christophebedard reviewed Mar 27, 2024
View reviewed changes
christophebedard
christophebedard reviewed Mar 27, 2024
View reviewed changes
h-suzuki-isp and others added 4 commits March 28, 2024 11:30
@h-suzuki-isp @christophebedard
Update test_tracetools/test/test_generic_subscription.py
2429083 
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: h-suzuki-isp <146712054+h-suzuki-isp@users.noreply.github.com>
@h-suzuki-isp
Update: updated to match the latest test_pub_sub.py
983cc23 
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
@h-suzuki-isp
Update: updated to match the latest test_subscription.py
9ddf39e 
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
@h-suzuki-isp
Fix: class name
0bbf692 
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
christophebedard
christophebedard approved these changes Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating!

Let's now wait for full CI (under the rclcpp PR) and perhaps some final reviews for the changes to the rmw implementations.

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Apr 5, 2024

Alright, all other PRs have been merged, so I'll merge this one. See ros2/rclcpp#2448 (comment) for CI.

Thank you for the contribution @h-suzuki-isp!

@christophebedard christophebedard merged commit a689891 into ros2:rolling Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-suzuki-isp @christophebedard