Add TRACEPOINT_ENABLED() and DO_TRACEPOINT() macros#46
Merged
christophebedard merged 1 commit intorollingfrom Feb 22, 2023
Merged
Conversation
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Member
Author
|
cc @iluetkeb |
mjcarroll
approved these changes
Feb 21, 2023
Member
mjcarroll
left a comment
There was a problem hiding this comment.
I think this is a reasonable path forward as it allows the most flexibility.
Member
Author
|
Testing
|
Member
Author
|
Alright, CI looks good. |
This was referenced Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
TRACEPOINT_ENABLED()andDO_TRACEPOINT()macros alongside the currentTRACEPOINT()macro. Thesetracetoolsmacros correspond to LTTng'stracepoint_enabled(),do_tracepoint(), andtracepoint()macros, respectively. See lttng-ust(3).During runtime, this allows first checking if the tracepoint is enabled before doing some processing and triggering the tracepoint manually. This way, we avoid doing unnecessary processing/memory allocations/etc. if the tracepoint isn't enabled.
Eventually, for tracers that do not support this mechanism, we can just
#define TRACEPOINT_ENABLED(...) trueand#define DO_TRACEPOINT(...) TRACEPOINT(__VA_ARGS__).Signed-off-by: Christophe Bedard christophe.bedard@apex.ai