Update tutorials to use the new command line syntax#376
Merged
clalancette merged 4 commits intomasterfrom Oct 24, 2019
Merged
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
clalancette
requested changes
Oct 23, 2019
Contributor
clalancette
left a comment
There was a problem hiding this comment.
I found one syntax error.
source/Tutorials/Node-arguments.rst
Outdated
| .. code-block:: bash | ||
|
|
||
| ros2 run demo_nodes_cpp talker __ns:=/demo __node:=my_talker chatter:=my_topic | ||
| ros2 run demo_nodes_cpp talker --ros-args -r __ns:=/demo -r __node:=my_talker chatter:=my_topic |
Contributor
There was a problem hiding this comment.
Suggested change
| ros2 run demo_nodes_cpp talker --ros-args -r __ns:=/demo -r __node:=my_talker chatter:=my_topic | |
| ros2 run demo_nodes_cpp talker --ros-args -r __ns:=/demo -r __node:=my_talker -r chatter:=my_topic |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
clalancette
approved these changes
Oct 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros2 run demo_nodes_cpp parameter_blackboard --ros-args -p "some_lists.some_integers:=[1, 2, 3, 4]"Fails printing:
[ERROR] [rcl]: Failed to parse global arguments.We have to correct that before merging.