Topic add matched event description#3406
Merged
fujitatomoya merged 4 commits intoros2:rollingfrom Apr 13, 2023
Merged
Conversation
11 tasks
clalancette
requested changes
Mar 27, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Besides the changes inline, we can't put this in until ros2/demos#607 is merged.
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with @clalancette 's comments.
fujitatomoya
approved these changes
Mar 28, 2023
Collaborator
|
@clalancette @audrow can you do us a favor? |
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
clalancette
approved these changes
Mar 28, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
This looks generally good to me, but we can't merge it until ros2/demos#607 is merged.
288035f to
49c8bf6
Compare
This was referenced Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ros2/rmw#330