Skip to content

Pin Fast-RTPS and Fast-CDR before releasing Eloquent #806

Merged
mjcarroll merged 1 commit intomasterfrom
ivanpauno/pin-fastrtps-fastcdr-eloquent
Oct 18, 2019
Merged

Pin Fast-RTPS and Fast-CDR before releasing Eloquent #806
mjcarroll merged 1 commit intomasterfrom
ivanpauno/pin-fastrtps-fastcdr-eloquent

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

I propose temporally pinning both, to decouple from their changes.
Particularly, there are a lot of changes going on in Fast-RTPS and cross-vendor tests started failing.

Pin Fast-RTPS to v1.9.2
Pin Fast-CDR to v1.0.11

Pin Fast-CDR to v1.0.11

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno requested a review from mjcarroll October 18, 2019 18:12
@mjcarroll mjcarroll merged commit a53d1f8 into master Oct 18, 2019
@delete-merged-branch delete-merged-branch Bot deleted the ivanpauno/pin-fastrtps-fastcdr-eloquent branch October 18, 2019 18:13
@dirk-thomas
Copy link
Copy Markdown
Member

Please reference the CI build results here.

@mjcarroll
Copy link
Copy Markdown
Member

Sorry, that was a bit trigger happy, @ivanpauno can you include the CI results?

@ivanpauno
Copy link
Copy Markdown
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Copy Markdown
Member Author

One including connext, to check cross-vendor tests:

  • Linux Build Status

@mjcarroll
Copy link
Copy Markdown
Member

mjcarroll commented Oct 19, 2019

This was the next rerun, pinned back to eProsima/Fast-DDS@9d56202 based on #801 (comment) and FastCDR at v1.0.11

Build Status

@ivanpauno
Copy link
Copy Markdown
Member Author

This was the next rerun, pinned back to eProsima/Fast-RTPS@9d56202 based on #801 (comment) and FastCDR at v1.0.11

Build Status

Completing the others:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll
Copy link
Copy Markdown
Member

@richiware I thought that we should bring this to your attention. It seems that using your 1.9.2 tag currently causes our cross-vendor tests (specifically between FastRTPS and Connext) to fail.

Our current workaround is to pin to the master branch at eProsima/Fast-DDS@9d56202

Can the 1.9.x branch be patched so that these tests will continue to pass, or is a new release (1.9.3?) coming that will fix this issue?

@dirk-thomas
Copy link
Copy Markdown
Member

Can the 1.9.x branch be patched so that these tests will continue to pass, or is a new release (1.9.3?) coming that will fix this issue?

Even with an upcoming patch release it would be good to get the patch backported to the 1.9.x branch asap. Otherwise we will have to use the specific commit hash from the master branch.

@MiguelCompany
Copy link
Copy Markdown
Contributor

@mjcarroll @dirk-thomas We would start with a patch for the 1.9.x branch directly. I've seen in the logs that you are using RTI Connext DDS 5.3.1, and it seems the problems are related to discovery. We are investigating the issue, and as I said a patch will come directly to the 1.9.x branch.

@MiguelCompany
Copy link
Copy Markdown
Contributor

@mjcarroll @dirk-thomas We found the issue (it only happened with versions 5.x of connext, 6.x was working correctly). The patch is going to 1.9.x on eProsima/Fast-DDS#806. When it is merged, I would suggest to pin Fast-RTPS to 1.9.x branch

@MiguelCompany
Copy link
Copy Markdown
Contributor

@mjcarroll @ivanpauno @dirk-thomas branch 1.9.x should work now that eProsima/Fast-DDS#806 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants