Skip to content

Fixed crashing discovery of ROS2 services#58

Merged
wjwwood merged 1 commit intoros2:masterfrom
haueck:fix_ros2_service_discovery
Feb 17, 2017
Merged

Fixed crashing discovery of ROS2 services#58
wjwwood merged 1 commit intoros2:masterfrom
haueck:fix_ros2_service_discovery

Conversation

@haueck
Copy link
Copy Markdown
Contributor

@haueck haueck commented Feb 17, 2017

No description provided.

@haueck haueck mentioned this pull request Feb 17, 2017
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Feb 17, 2017

Unfortunately our CI doesn't currently test the ROS 1 bridge, but I can run a Linux packaging job with this change to check for compiler errors and warnings:

Build Status

@Karsten1987 or @jhoare could either of you manually test this patch?

@wjwwood wjwwood requested a review from Karsten1987 February 17, 2017 21:52
@wjwwood wjwwood added the bug Something isn't working label Feb 17, 2017
@Karsten1987
Copy link
Copy Markdown
Contributor

Karsten1987 commented Feb 17, 2017

that looks good to me.
+1

@wjwwood wjwwood merged commit b974659 into ros2:master Feb 17, 2017
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Feb 17, 2017

Thanks @haueck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants