Skip to content

Don't use launch_testing features that will be deprecated#222

Merged
sloretz merged 1 commit intoros2:masterfrom
pbaughman:update_tests
Oct 21, 2019
Merged

Don't use launch_testing features that will be deprecated#222
sloretz merged 1 commit intoros2:masterfrom
pbaughman:update_tests

Conversation

@pbaughman
Copy link
Copy Markdown
Contributor

@pbaughman pbaughman commented Oct 18, 2019

Removing some of the 'magic' features from launch_testing that we want to deprecate.

For background, see ros2/launch#346

Signed-off-by: Pete Baughman pete.baughman@apex.ai

Don't use features that will be deprecated
8f9cd1b 
Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
@pbaughman pbaughman mentioned this pull request Oct 18, 2019
Merged
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Oct 21, 2019 •
edited
Loading

CI (testing just ros1_bridge on linux)
Build Status (java traceback)
Build Status

@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Oct 21, 2019

CI looks good. Unstable due to

--- stderr: ros1_bridge
12:47:04 CMake Warning at /home/jenkins-agent/workspace/ci_packaging_linux/ws/install/share/actionlib_msgs/cmake/actionlib_msgsConfig.cmake:29 (message):
12:47:04   Package 'actionlib_msgs' is deprecated (This package will be removed in a
12:47:04   future ROS distro, once the ROS 1 bridge supports actions.)
12:47:04 Call Stack (most recent call first):
12:47:04   CMakeLists.txt:94 (find_package)
12:47:04 
12:47:04 
12:47:04 ---
12:47:04 Finished <<< ros1_bridge [22min 20s]
12:47:04 
12:47:04 Summary: 1 package finished [22min 22s]
12:47:04   1 package had stderr output: ros1_bridge
12:47:04 
12:47:04 # END SUBSECTION

@sloretz sloretz requested a review from mjcarroll October 21, 2019 21:21
mjcarroll
mjcarroll approved these changes Oct 21, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, actionlib_msgs deprecation warning is expected (and happens on nightly)

@sloretz sloretz merged commit 94561bf into ros2:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@sloretz sloretz sloretz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pbaughman @sloretz @mjcarroll