Support for ON_REQUESTED_INCOMPATIBLE_QOS and ON_OFFERED_INCOMPATIBLE_QOS events #294
Support for ON_REQUESTED_INCOMPATIBLE_QOS and ON_OFFERED_INCOMPATIBLE_QOS events #294jaisontj wants to merge 4 commits intoros2:masterfrom
Conversation
OFFERED_INCOMPATIBLE_QOS_STATUS Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
f1bfeda to
826fe07
Compare
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
| virtual void on_publication_matched( | ||
| DDS::DataWriter_ptr writer, | ||
| const DDS::PublicationMatchedStatus & status); | ||
|
|
There was a problem hiding this comment.
Removed new line to make code style more consistent with the rest of the file.
There was a problem hiding this comment.
Please, avoid unrelated changes.
In any case, adding the missing spaces in other places would be better.
ivanpauno
left a comment
There was a problem hiding this comment.
Just one nit, otherwise LGTM!
| virtual void on_publication_matched( | ||
| DDS::DataWriter_ptr writer, | ||
| const DDS::PublicationMatchedStatus & status); | ||
|
|
There was a problem hiding this comment.
Please, avoid unrelated changes.
In any case, adding the missing spaces in other places would be better.
|
Is |
While
I would think no since this feature targets Foxy and isn't intended to be backported to older distros anyway. |
|
Great! Then anybody with permission may close this pull request (I don't have the permission to). |
Must not be merged before ros2/rmw:193 is merged. The build will fail until then since the required enums have been defined in that PR.
Related to this feature request. The design and implementation details can also be found there.
Handling events of type
REQUESTED_INCOMPATIBLE_QOS_STATUSandOFFERED_INCOMPATIBLE_QOS_STATUSSigned-off-by: Jaison Titus jaisontj92@gmail.com