This repository was archived by the owner on Oct 7, 2021. It is now read-only.
Merged
Conversation
4e3f597 to
55ad598
Compare
55ad598 to
e5b053e
Compare
Karsten1987
reviewed
May 9, 2018
| if (!process_service_name( | ||
| service_name_.c_str(), avoid_ros_namespace_conventions, service_str, | ||
| request_partition_name, response_partition_name)) | ||
| request_str, response_str)) |
Contributor
There was a problem hiding this comment.
why not pass request_topic_name and response_topic_name directly here?
| request_topic_name = service_str + "Request"; | ||
| response_topic_name = service_str + "Reply"; | ||
|
|
||
| request_topic_name = request_str; |
Contributor
There was a problem hiding this comment.
see comment above. Doesn't need to copy
| if (!process_service_name( | ||
| service_name_.c_str(), avoid_ros_namespace_conventions, service_str, | ||
| request_partition_name, response_partition_name)) | ||
| request_str, response_str)) |
bd02b53 to
0f09573
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects to ros2/ros2#476
To use the topic/service name directly without using the partitions.