Skip to content
This repository was archived by the owner on Oct 7, 2021. It is now read-only.

update to support new rmw API with namespaces#164

Merged
wjwwood merged 1 commit intomasterfrom
node_namespace
Apr 8, 2017
Merged

update to support new rmw API with namespaces#164
wjwwood merged 1 commit intomasterfrom
node_namespace

Conversation

@wjwwood
Copy link
Copy Markdown
Member

@wjwwood wjwwood commented Mar 30, 2017

Connects to ros2/rmw#95

@wjwwood wjwwood added enhancement New feature or request in review Waiting for review (Kanban column) labels Mar 30, 2017
@wjwwood wjwwood self-assigned this Mar 30, 2017
@wjwwood wjwwood merged commit a3278c8 into master Apr 8, 2017
@wjwwood wjwwood deleted the node_namespace branch April 8, 2017 09:04
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Apr 8, 2017
}
memcpy(const_cast<char *>(node->name), name, strlen(name) + 1);

node->namespace_ = reinterpret_cast<const char *>(rmw_allocate(sizeof(char) * strlen(namespace_) + 1));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This memory is never freed. See #194.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants