API to enable log severity setting. #30
Merged
dirk-thomas merged 3 commits intoros2:masterfrom Jan 18, 2018
Merged
Conversation
ros2/rmw#124 url on rmw. The patch enables setting log severity from userland applications. The parameter passed is defined inside rmw/include/types.h Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>
dirk-thomas
reviewed
Oct 20, 2017
rmw_implementation/src/functions.cpp
Outdated
|
|
||
| RMW_INTERFACE_FN(rmw_set_log_severity, | ||
| rmw_ret_t, RMW_RET_ERROR, | ||
| 1, ARG_TYPES(const rmw_log_severity_t *)) |
Member
There was a problem hiding this comment.
Since rmw_log_severity_t is a primitive type this doesn't need to be passed as const *. A plain rmw_log_severity_t is sufficient.
addressing comments Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>
Contributor
Author
|
@dirk-thomas fixed the comment. |
dirk-thomas
approved these changes
Oct 20, 2017
Member
dirk-thomas
left a comment
There was a problem hiding this comment.
The patch looks good. Merging needs to wait until the rmw interface specifies the new function and the rmw implementations implement it.
Contributor
Author
|
@dirk-thomas Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros2/rmw#124 url on rmw.
The patch enables setting log severity from userland applications. The parameter
passed is defined inside rmw/include/types.h
Signed-off-by: Sriram Raghunathan sriram.max@gmail.com
Connect to ros2/rmw#124