Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
clalancette
left a comment
There was a problem hiding this comment.
Seems reasonable to me, @hidmic should we merge?
|
Catching the exception seems reasonable to me, that the parameter type is , rather than updating the parameter type for What do you think about that? |
|
@iuhilnehc-ynos that's reasonable, but it doesn't preclude the need for this patch. Unless we make those methods |
|
Alright, from what I can observe in above's partial coverage computations, this patch does not appreciably degrade coverage. I'll go ahead and merge. Let's see what nightlies have to say. |
This will reduce coverage somewhat, as the conditions on which these exceptions are generated cannot be reproduced (yet).
CI up to
rmw_implementation,test_rmw_implementation, andrcl: