Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
| # `rmw_implementation` Quality Declaration | ||
|
|
||
| The package `rmw_implementation` claims to be in the **Quality Level 3** category. | ||
| The package `rmw_implementation` claims to be in the **Quality Level 1** category. |
There was a problem hiding this comment.
I believe this package is blocked from level 1 by its dependencies. It can only be level 2 right now, like rcpputils, rcutils and rmw.
I see that rmw_implementation_cmake is also mentioned in the dependencies section, but is that a runtime dependency? We haven't been tracking it.
There was a problem hiding this comment.
All good points:
- For
rcutils, we're lacking performance tests (or a justification to not have them) to bump it to QL1. - For
rcpputils, we're a bit under 90% coverage and we're lacking performance tests (or a justification to not have them) to bump it to QL1. - For
rmw, we're lacking performance tests (or a justification to not have them) to bump it to QL1.
These constraints apply to implementations as well.
About rmw_implementation_cmake, I think it's a build tool, build, and build export dependency, but not a runtime nor test dependency. I also don't see clearly what's missing there for QL1 besides proper justifications for missing tests (unless we decide we want to start testing CMake code, which I presume it's not the case).
There was a problem hiding this comment.
I'll relax to QL2 to get this going.
Precisely what the title says.