Dynamic Subscription (BONUS: Allocators): rmw_fastrtps#687
Merged
methylDragon merged 4 commits intorollingfrom Apr 11, 2023
Merged
Dynamic Subscription (BONUS: Allocators): rmw_fastrtps#687methylDragon merged 4 commits intorollingfrom
methylDragon merged 4 commits intorollingfrom
Conversation
Signed-off-by: methylDragon <methylDragon@gmail.com>
28 tasks
Signed-off-by: methylDragon <methylDragon@gmail.com>
2ec70eb to
37ba2d3
Compare
wjwwood
approved these changes
Apr 10, 2023
emersonknapp
approved these changes
Apr 10, 2023
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
clalancette
requested changes
Apr 10, 2023
Comment on lines
+93
to
+94
| rosidl_dynamic_typesupport_serialization_support_init( | ||
| &impl, &methods, allocator, serialization_support)); |
Contributor
There was a problem hiding this comment.
This is pre-existing, but I'll point out that this looks like a bug; if rosidl_dynamic_typesupport_serialization_support_init fails, then we'll leak &impl and &methods, no?
Contributor
Author
There was a problem hiding this comment.
Yeah, will defer to after the merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: ros2/ros2#1405