Closed
Conversation
0f5fa7c to
02e791e
Compare
hidmic
reviewed
Mar 26, 2021
rmw_fastrtps_dynamic_cpp/include/rmw_fastrtps_dynamic_cpp/TypeSupport_impl.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
5578b38 to
40a3430
Compare
This was referenced Apr 12, 2021
Collaborator
Author
|
@hidmic I already applied your suggestion here. Would you mind reviewing? |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
40a3430 to
f7f275c
Compare
hidmic
approved these changes
May 5, 2021
Collaborator
Author
|
Closing this, as it is included on #523, which has already been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for
is_bounded()andis_plain()to ease integration of data-sharing and zero-copy features of Fast DDS.Connects to ros2/rosidl_typesupport_fastrtps#67