[foxy] Use interface whitelist for localhost only (#476)#514
Merged
fujitatomoya merged 1 commit intoros2:foxyfrom Mar 8, 2021
Merged
[foxy] Use interface whitelist for localhost only (#476)#514fujitatomoya merged 1 commit intoros2:foxyfrom
fujitatomoya merged 1 commit intoros2:foxyfrom
Conversation
* Use interface whitelist for localhost only Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Collaborator
Author
|
requesting review just in case. i confirmed this fixes the ros2/ros2#1096 (originally ros2/ros2#1052) with foxy repo. |
Collaborator
Author
|
CI:
|
This was referenced Mar 5, 2021
Collaborator
Author
|
CI looks okay, waiting for the review. |
mitsudome-r
approved these changes
Mar 5, 2021
mitsudome-r
left a comment
There was a problem hiding this comment.
LGTM.
I have checked on my machine that it fixes the problem when ROS_LOCALHOST_ONLY is set.
Before (listener node is not being able to receive messages from all talkers):
After:
Collaborator
Author
|
@mitsudome-r thanks for checking, let's wait it out for a bit. i do need another review on this. @richiware @MiguelCompany friendly ping for review. |
MiguelCompany
approved these changes
Mar 8, 2021
Collaborator
MiguelCompany
left a comment
There was a problem hiding this comment.
LGTM. Thanks @fujitatomoya
Collaborator
Author
|
windows CI is unrelated to this fix, going in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
foxy backport of #476