Skip to content

Extend XML examples#504

Merged
hidmic merged 2 commits intoros2:masterfrom
eProsima:feature/readme_profiles
Jan 20, 2021
Merged

Extend XML examples#504
hidmic merged 2 commits intoros2:masterfrom
eProsima:feature/readme_profiles

Conversation

@EduPonz
Copy link
Copy Markdown

@EduPonz EduPonz commented Jan 19, 2021

This PR extends XML examples to include different profile types selected by name.

Signed-off-by: EduPonz eduardoponz@eprosima.com

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

README.md Outdated
##### Creating publishers/subscriptions with different profiles

To configure a publisher/subscription, define a `<publisher>`/`<subscriber>` profile with attribute `profile_name=topic_name`.
To configure a publisher/subscription, define a `<publisher>`/`<subscriber>` profile with attribute `profile_name=topic_name`, where topic name is the name of the topic before mangling, i.e. the topic name used to create the publisher/subscription on `rclcpp`/`rclpy`.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EduPonz consider not mentioning client libraries directly to stay general (as examples at most)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4909e2b

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic hidmic merged commit 1853a83 into ros2:master Jan 20, 2021
@EduPonz EduPonz mentioned this pull request Jan 21, 2021
@MiguelCompany MiguelCompany deleted the feature/readme_profiles branch April 6, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants