Skip to content

[foxy] Avoid unused identifier variable warnings (#422)#494

Merged
jacobperron merged 1 commit intofoxyfrom
jacob/foxy_backport_422
Jan 12, 2021
Merged

[foxy] Avoid unused identifier variable warnings (#422)#494
jacobperron merged 1 commit intofoxyfrom
jacob/foxy_backport_422

Conversation

@jacobperron
Copy link
Copy Markdown
Member

Backport #422 to Foxy.

This should resolve compiler warnings in release builds, e.g. https://ci.ros2.org/job/ci_packaging_osx/79/clang/

Fixes regression introduced by 94b379e.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green Foxy CI

@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Jan 12, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (unrelated cmake warnings)

@jacobperron jacobperron merged commit 684b10b into foxy Jan 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the jacob/foxy_backport_422 branch January 12, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants